Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: Add recursive implication function for lists #12855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@ahmadharbi0x1337 ahmadharbi0x1337 commented Jul 21, 2025

Describe your change:

This pull request introduces a new function, recursive_imply_list, which calculates the implication of a list of boolean values (0 or 1) by applying the implication operation recursively from left to right.

It builds upon the existing imply_gate function.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copy link
Contributor Author

hello there , hope you doing well all, i'm kind of a beginner in this contribution things , Mr.mindaugl thank you for the approval and off-course i appreciate the effort you took to check and review, but it's still saying from my end "merging is blocked at least 1 approving review is required by reviewers with write access".
is there a specific contributor with write access to point the pull to for approval ?
@mindaugl

Copy link
Contributor Author

hello all , hope you are doing well , appreciate the effort Mr.anandfresh for review and approval, nevertheless it's still saying merging is blocked and review is required 😅. is there something i should do ?

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 24, 2025
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 24, 2025
@MaximSmolskiy MaximSmolskiy merged commit d16cac6 into TheAlgorithms:master Aug 24, 2025
5 checks passed
@ahmadharbi0x1337 ahmadharbi0x1337 deleted the feat/recursive-list-imply branch August 24, 2025 20:30
Copy link
Contributor Author

thank you so much all for your effort, mr.mindaugl and mr.anandfresh and mr.maximsmolskiy, i appreciate the effort you put in the review and approval .
hope to contribute more to this society .

thank you all again .

cclauss pushed a commit to cclauss/Python that referenced this pull request Aug 25, 2025 
* feat: Add recursive implication function for lists
* Update imply_gate.py
* Update imply_gate.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: Maxim Smolskiy <mithridatus@mail.ru>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximSmolskiy MaximSmolskiy MaximSmolskiy approved these changes

+2 more reviewers

@anandfresh anandfresh anandfresh approved these changes

@mindaugl mindaugl mindaugl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /