-
-
Notifications
You must be signed in to change notification settings - Fork 47.7k
Fix RuntimeError in bipartite-check DFS/BFS and clean up doctests #12814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaximSmolskiy
merged 12 commits into
TheAlgorithms:master
from
mohiuddin-khan-shiam:master
Aug 24, 2025
Merged
Fix RuntimeError in bipartite-check DFS/BFS and clean up doctests #12814
MaximSmolskiy
merged 12 commits into
TheAlgorithms:master
from
mohiuddin-khan-shiam:master
Aug 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Iteration over `graph` mutated by `defaultdict` neighbours caused `RuntimeError: dictionary changed size during iteration`. – Iterate over `list(graph)` in both DFS and BFS helpers. * Corrected `if __name__ == "__main__":` typo. * Updated two doctests that now succeed after the fix. All doctests now pass (`30/30`), eliminating a critical runtime failure and improving reliability of the graph algorithms. Co-Authored-By: S. M. Mohiuddin Khan Shiam <147746955+mohiuddin-khan-shiam@users.noreply.github.com>
Iteration over graph mutated by defaultdict neighbours caused RuntimeError: dictionary changed size during iteration. – Iterate over list(graph) in both DFS and BFS helpers. Corrected if __name__ == "__main__": typo. Updated two doctests that now succeed after the fix. All doctests now pass (30/30), eliminating a critical runtime failure and improving reliability of the graph algorithms.
@algorithms-keeper
algorithms-keeper
bot
added
the
awaiting reviews
This PR is ready to be reviewed
label
Aug 24, 2025
@algorithms-keeper
algorithms-keeper
bot
added
the
tests are failing
Do not merge until tests pass
label
Aug 24, 2025
@algorithms-keeper
algorithms-keeper
bot
removed
the
tests are failing
Do not merge until tests pass
label
Aug 24, 2025
MaximSmolskiy
MaximSmolskiy
approved these changes
Aug 24, 2025
@algorithms-keeper
algorithms-keeper
bot
removed
the
awaiting reviews
This PR is ready to be reviewed
label
Aug 24, 2025
@MaximSmolskiy
MaximSmolskiy
merged commit Aug 24, 2025
561cc38
into
TheAlgorithms:master
5 checks passed
cclauss
pushed a commit
to cclauss/Python
that referenced
this pull request
Aug 25, 2025
...eAlgorithms#12814) * Fix `RuntimeError` in bipartite-check DFS/BFS and clean up doctests * Iteration over `graph` mutated by `defaultdict` neighbours caused `RuntimeError: dictionary changed size during iteration`. – Iterate over `list(graph)` in both DFS and BFS helpers. * Corrected `if __name__ == "__main__":` typo. * Updated two doctests that now succeed after the fix. All doctests now pass (`30/30`), eliminating a critical runtime failure and improving reliability of the graph algorithms. Co-Authored-By: S. M. Mohiuddin Khan Shiam <147746955+mohiuddin-khan-shiam@users.noreply.github.com> * Update check_bipatrite.py * Update check_bipatrite.py * Update check_bipatrite.py * Update check_bipatrite.py * Update check_bipatrite.py * Update check_bipatrite.py * Update check_bipatrite.py * Update check_bipatrite.py * Update check_bipatrite.py --------- Co-authored-by: Odio Marcelino <odiomarcelino@gmail.com> Co-authored-by: Maxim Smolskiy <mithridatus@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
RuntimeErrorin bipartite-check DFS/BFS and clean up doctestsDescription
graphmutated bydefaultdictneighbours causedRuntimeError: dictionary changed size during iteration.– Iterate over
list(graph)in both DFS and BFS helpers.if __name__ == "__main__":typo.All doctests now pass (
30/30), eliminating a critical runtime failure and improving reliability of the graph algorithms.