Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Performance: 25% faster Project Euler 73 #10503 #11553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@RamanaMenda RamanaMenda commented Sep 6, 2024 •
edited
Loading

Describe your change:

#8594

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 6, 2024
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Sep 6, 2024
Copy link
Contributor Author

Hi @cclauss & @imSanko: Looking forward for your review

Copy link
Contributor

@imSanko imSanko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try some more test such as:

import unittest
class TestSolution(unittest.TestCase):
 def test_small_max_d(self):
 self.assertEqual(solution(4), 0)
 self.assertEqual(solution(5), 1)
 self.assertEqual(solution(8), 3)
 def test_large_max_d(self):
 self.assertEqual(solution(12000), 7193) # Expected result
 def test_invalid_input(self):
 with self.assertRaises(ValueError):
 solution(-1)
 with self.assertRaises(ValueError):
 solution(0)
if __name__ == "__main__":
 unittest.main()

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 30, 2025
@MaximSmolskiy MaximSmolskiy merged commit 488f143 into TheAlgorithms:master Aug 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximSmolskiy MaximSmolskiy MaximSmolskiy approved these changes

+2 more reviewers

@imSanko imSanko imSanko requested changes

@BALAJI24092001 BALAJI24092001 BALAJI24092001 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /