Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update LRUCache.js #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awojobigodfrey wants to merge 2 commits into TheAlgorithms:master from awojobigodfrey:patch-1

Conversation

Copy link

@awojobigodfrey awojobigodfrey commented Apr 18, 2022 •
edited
Loading

Added a clear function for cache

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
 

Added a clear function for cache
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please - at the very least - fix your indentation. Why is this feature necessary? Why can't I just call obj.cache.clear()?

Copy link
Member

obj.clear() is less clear then obj.cache.clear() imo.

@@ -83,6 +83,11 @@ class LRUCache {
this.cache.set(key, value)
}

clear () {
this.cache.clear()
return this
Copy link
Member

@CarlosZoft CarlosZoft Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why returns "this"?

appgurueu reacted with thumbs up emoji
Copy link
Member

@appgurueu should I close this? We both seem to think it is unnecessary and less readable.
appgurueu reacted with thumbs up emoji

@appgurueu appgurueu added the wontfix Will not be fixed or is a feature label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

+1 more reviewer

@CarlosZoft CarlosZoft CarlosZoft left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
wontfix Will not be fixed or is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /