Skip to content

Optimized code #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

utsav0 wants to merge 8 commits into TheAlgorithms:master from utsav0:optimising

Closed

Optimized code #951

Changes from 5 commits

Commits

Show all changes

Select commit Hold shift + click to select a range

Fixed a typo where the commenting was wrong

utsav0 Mar 25, 2022

utsav0 Mar 26, 2022

Update SetBit.js

utsav0 Mar 27, 2022

Update SetBit.js

utsav0 Mar 27, 2022

Update FindLcm.js

utsav0 Mar 27, 2022

Replaced let with const

utsav0 Mar 28, 2022

Remove trailing spacing

appgurueu Apr 27, 2022

Merge branch 'master' into optimising

raklaptudirm Apr 27, 2022

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

12 changes: 3 additions & 9 deletions Maths/FindLcm.js

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -22,16 +22,10 @@ const findLcm = (num1, num2) => {
		if (num1 !== Math.round(num1) \|\| num2 !== Math.round(num2)) {
		return 'Please enter whole numbers.'
		}

	let maxNum
	let lcm

appgurueu marked this conversation as resolved. Outdated Show resolved Hide resolved
		// Check to see whether num1 or num2 is larger.
	if (num1 > num2) {
	maxNum = num1
	} else {
	maxNum = num2
	}
	lcm = maxNum
	let maxNum = Math.max(num1, num2)
	let lcm = maxNum

		while (true) {
		if (lcm % num1 === 0 && lcm % num2 === 0) break
Expand Down