Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Algorithm to calculate the Arithmetic Geometric Mean #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 14 commits into TheAlgorithms:master from Rudxain:patch-1
Feb 24, 2022
Merged

Algorithm to calculate the Arithmetic Geometric Mean #897

raklaptudirm merged 14 commits into TheAlgorithms:master from Rudxain:patch-1
Feb 24, 2022

Conversation

Copy link
Contributor

@Rudxain Rudxain commented Feb 20, 2022 •
edited
Loading

Added an algorithm to compute/find the Arithmetic-Geometric Mean between 2 numbers a and g. I thought it would be a good idea since it shows how to compute at full precision without an epsilon comparison, and there's already an Arithmetic Mean so I added this for completeness.

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the algorithm.

Rudxain reacted with thumbs up emoji
Copy link
Contributor Author

Rudxain commented Feb 23, 2022 •
edited
Loading

Please add tests for the algorithm.

I committed the test script now, but the "build" stage says that none of the methods are functions. "toBe is not a function", and "toEqual is not a function". Is this normal?

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toBe should be outside expect. Please fix all the instances where you put it inside.

Copy link
Contributor Author

Rudxain commented Feb 23, 2022

My bad, sorry. I didn't notice. I'll fix it now

Copy link
Contributor Author

Rudxain commented Feb 23, 2022

I'll fix the other bugs now

@raklaptudirm raklaptudirm changed the title (削除) Create ArithmeticGeometricMean.js (削除ここまで) (追記) Algorithm to calculate the Arithmetic Geometric Mean (追記ここまで) Feb 24, 2022
@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm feature Adds a new feature Reviewed labels Feb 24, 2022
@raklaptudirm raklaptudirm merged commit 0178efd into TheAlgorithms:master Feb 24, 2022
@Rudxain Rudxain deleted the patch-1 branch February 26, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /