Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add Implementation for Sum of Geometric Progression #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 2 commits into TheAlgorithms:master from SpiderMath:master
Oct 23, 2021
Merged

Add Implementation for Sum of Geometric Progression #807

raklaptudirm merged 2 commits into TheAlgorithms:master from SpiderMath:master
Oct 23, 2021

Conversation

Copy link
Contributor

@SpiderMath SpiderMath commented Oct 23, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

I added the implementation for Sum of GP

Copy link
Contributor Author

SpiderMath commented Oct 23, 2021 •
edited
Loading

Just a question, I've made it so that if someone inputs Infinity as the number of terms in the algorithm, and the magnitude of common ratio is more than or equal to 1, I throw an Error since the series is divergent.
Is that okay? Or do I just return Infinity as the response (because that could be a possible response 🤷 )

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm feature Adds a new feature Reviewed labels Oct 23, 2021
@raklaptudirm raklaptudirm merged commit cd3974c into TheAlgorithms:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /