Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Reduced and optimized code #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devraj4522 wants to merge 1 commit into TheAlgorithms:master from devraj4522:patch-1
Closed

Reduced and optimized code #796

devraj4522 wants to merge 1 commit into TheAlgorithms:master from devraj4522:patch-1

Conversation

Copy link

@devraj4522 devraj4522 commented Oct 19, 2021 •
edited
Loading

Merged two if statements

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
 

Merged two if statements
Copy link

lgtm-com bot commented Oct 19, 2021

This pull request introduces 1 alert when merging 0da5aa9 into a9d2051 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature invalid Doesn't seem right and removed feature Adds a new feature changes required This pull request needs changes labels Oct 20, 2021
Copy link
Member

I do not consider the following changes to be an improvement to the code.
trasherdk reacted with laugh emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm invalid Doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /