Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Rotting Orange Algorithm #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camiloibarrayepes wants to merge 2 commits into TheAlgorithms:master from camiloibarrayepes:newChallengeAlgorithm
Closed

Rotting Orange Algorithm #778

camiloibarrayepes wants to merge 2 commits into TheAlgorithms:master from camiloibarrayepes:newChallengeAlgorithm

Conversation

Copy link

@camiloibarrayepes camiloibarrayepes commented Oct 12, 2021

#765
An Amazon coding interview question: Rotting orange in Javascript Language

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #765 .
 

#765
An Amazon coding interview question: Rotting orange in Javascript Language
@raklaptudirm raklaptudirm added the on hold Being discussed by the maintainers label Oct 12, 2021
Copy link
Author

please don't forget my pr @raklaptudirm

Copy link
Member

@cclauss Please give your opinion on whether this algorithm should be accepted or not.

}
}
return ans;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛔ is GitHub saying that it expects all files to end with one and only one carriage return (\n).

Copy link
Member

cclauss commented Oct 16, 2021

Are there tests included in this submission?

Copy link
Member

I will take that as an approval.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes code style issue Failing style checks Reviewed and removed on hold Being discussed by the maintainers labels Oct 16, 2021
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style your code with standard.js and add jest tests to it.

Return the minimum number of minutes that must elapse until no cell has a fresh orange. If this is impossible, return -1. */


var dx = [-1,0,+1,0];
Copy link
Member

@raklaptudirm raklaptudirm Oct 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put everything into a function.

Copy link
Member

cclauss commented Oct 16, 2021 •
edited
Loading

I would not approve if there are no tests.

Also, there is currently a ❌ below.

Copy link
Member

No I meant the algorithm, is it a proper algorithm according to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@raklaptudirm raklaptudirm raklaptudirm requested changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm changes required This pull request needs changes code style issue Failing style checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /