Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Added CycleNode Algorithm #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copy link
Contributor

@chiranjeev-thapliyal chiranjeev-thapliyal commented Oct 7, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Added CycleNode algorithm which finds the first node where the cycle begins in a linked list.
  • Added module support in package.json
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@raklaptudirm raklaptudirm added the on hold Being discussed by the maintainers label Oct 7, 2021
package.json Outdated
}
}
},
"type": "module"
Copy link
Member

@raklaptudirm raklaptudirm Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these changes.

Copy link
Member

@raklaptudirm raklaptudirm Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have still not been removed.

For reference: https://www.codingninjas.com/blog/2020/09/09/floyds-cycle-detection-algorithm/
*/

const detectCycleNode = (head) => {
Copy link
Member

@raklaptudirm raklaptudirm Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a specification for head. What type of input do you expect?

Copy link
Member

@raklaptudirm raklaptudirm Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not what I meant. I mean what properties and function do you expect the head parameter to implement. Write a specification for the head parameter.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed and removed on hold Being discussed by the maintainers labels Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm requested changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /