Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Change MaxHeap to more generic BinaryHeap #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mayankkamboj47 wants to merge 8 commits into TheAlgorithms:master from mayankkamboj47:master
Closed

Change MaxHeap to more generic BinaryHeap #753

mayankkamboj47 wants to merge 8 commits into TheAlgorithms:master from mayankkamboj47:master

Conversation

Copy link

@mayankkamboj47 mayankkamboj47 commented Oct 7, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
 

BinaryHeap takes a function as argument which can be used to
create MaxHeaps, MinHeaps or heaps with non-numerical nodes.
@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 7, 2021
@@ -0,0 +1,16 @@
const BinaryHeap = require('../BinaryHeap').BinaryHeap
test('Binary Heap works as a Max Heap', function () {
Copy link
Member

@raklaptudirm raklaptudirm Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some more tests for all the functions separately.

Copy link
Member

@mayankkamboj47 Looks like github completely forgot to notify me of new changes for 6 months. Check if the conflicts are resolvable.

Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Will not be fixed or is a feature label Apr 16, 2022
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Apr 30, 2022
@appgurueu appgurueu removed the wontfix Will not be fixed or is a feature label May 4, 2022
@stale stale bot removed the stale Closed due to age label May 4, 2022
@raklaptudirm raklaptudirm added abandoned This pull request has been abandoned conflicts This pull request has merge conflicts and removed reviewed labels May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm requested changes

Assignees
No one assigned
Labels
abandoned This pull request has been abandoned algorithm Adds or improves an algorithm changes required This pull request needs changes conflicts This pull request has merge conflicts feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /