Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add Problem4 (Largest Palindrome Product) #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmotaf wants to merge 6 commits into TheAlgorithms:master from fmotaf:master
Closed

Add Problem4 (Largest Palindrome Product) #751

fmotaf wants to merge 6 commits into TheAlgorithms:master from fmotaf:master

Conversation

Copy link

@fmotaf fmotaf commented Oct 6, 2021 •
edited
Loading

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link

lgtm-com bot commented Oct 6, 2021

This pull request introduces 1 alert when merging 7a12160 into 6eeb989 - view on LGTM.com

new alerts:

  • 1 for Syntax error

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the raised alerts.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 6, 2021
Copy link
Author

fmotaf commented Oct 6, 2021

Hi @raklaptudirm, i've changed the code, can you please do another review, thanks.

let d
let limit
let number = 0
function isPalindrome (number) {
Copy link
Member

@raklaptudirm raklaptudirm Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments with a link to the problem.

}

console.log(largestPalindromic(3))
console.log(isPalindrome(9009))
Copy link
Member

@raklaptudirm raklaptudirm Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the original function console logged, but it will be better if you remove the console logs and add jest tests instead.

@raklaptudirm raklaptudirm added the abandoned This pull request has been abandoned label Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm requested changes

Assignees
No one assigned
Labels
abandoned This pull request has been abandoned algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /