-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Project Euler - Problem 16 #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi folks - I've just now stumbled upon this discussion. @lvlte, I do understand the frustration and am sorry if there's a bit confusion going on right now.
TBH there have been several different styles how algorithm implementation code is supposed to look and how it's supposed to be run (i.e. tested):
- Simple JS files containing the algorithm itself + "test driver" code that outputs the results to the cconsole. Those algorithms are tested by simply running the whole JS file in node (CommonJS style.)
(削除) JS files with doctest comments (削除ここまで)(we just got rid of those)- JS files that adhere to ESM + dedicated test files. Tests are run through Jest, which picks up the babel config.
- ... and a bit of a wild mix altogether ;)
We discussed this in #720 where we decided that, the code shall be more consistent. Going forward, it makes sense to push towards ESM only (eventually just add the "type": "module"
property in the package.json and remove the need for babel altogether. But we're not there yet ;)
So please try to write new additions ESM-style, without console.log, with export function myAlgorithm
etc. + tests written in Jest. While this may be inconsistent at this moment with previous contributions, we're pushing towards migrating all existing code into the targeted style.
Uh oh!
There was an error while loading. Please reload this page.
Welcome to JavaScript community
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.