Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update NQueen.js #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timilion wants to merge 1 commit into TheAlgorithms:master from timilion:patch-1
Closed

Update NQueen.js #574

timilion wants to merge 1 commit into TheAlgorithms:master from timilion:patch-1

Conversation

Copy link

@timilion timilion commented Mar 3, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Member

@ruppysuppy ruppysuppy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the tests pass and go through the CONTRIBUTING.md before contributing. You can use standard to fix the styling issue

@ruppysuppy ruppysuppy added changes required This pull request needs changes code style issue Failing style checks labels Mar 4, 2021
@itsvinayak itsvinayak added the beginner-friendly Easy to implement label Apr 3, 2021
Copy link
Member

@timilion I am pinging because this PR seems to have been abandoned.

Copy link
Contributor

mhihasan commented Jun 5, 2021

May I fix and make new PR? @raklaptudirm

Copy link
Member

@mhihasan Sure go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy ruppysuppy requested changes

Assignees
No one assigned
Labels
beginner-friendly Easy to implement changes required This pull request needs changes code style issue Failing style checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /