Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Added Insertion sort in javascript. #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copy link

@Utkarsh-byte-bot Utkarsh-byte-bot commented Oct 31, 2020 •
edited
Loading

Welcome to JavaScript community

Describe your change:

Added Insertion sort in javascript.

  • [ Add more algorithms #14 Worked on this issue.. ] Add an algorithm?
  • [ Added new algorithm] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@marsonya marsonya added the code style issue Failing style checks label Dec 17, 2020
@marsonya marsonya self-requested a review December 17, 2020 07:39
Copy link
Contributor

Kindly make sure your contribution psses all Checks. Use standard as mentioned in CONTRIBUTING.md.

Quick Fix:- Run standard --fix to automatically fix some problems.

Copy link
Contributor

I think this may be abandoned, but I'll ping one more time, because I think it's great work! @Utkarsh-byte-bot, could you rebase this and fix the errors?

@marsonya marsonya added the changes required This pull request needs changes label Dec 30, 2020
Copy link
Contributor

marsonya commented Jan 2, 2021

Please reopen this pull request once you commit the changes requested or make improvements on the code. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya Awaiting requested review from marsonya

Assignees
No one assigned
Labels
changes required This pull request needs changes code style issue Failing style checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /