-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix: improve mean function with input validation and extended tests #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raklaptudirm
merged 1 commit into
TheAlgorithms:master
from
FatihBARACKILIC:fix/improve-AverageMean
Sep 4, 2025
Merged
fix: improve mean function with input validation and extended tests #1785
raklaptudirm
merged 1 commit into
TheAlgorithms:master
from
FatihBARACKILIC:fix/improve-AverageMean
Sep 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@FatihBARACKILIC
FatihBARACKILIC
requested review from
raklaptudirm and
appgurueu
as code owners
July 20, 2025 07:16
codecov-commenter
commented
Jul 20, 2025
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 85.88%. Comparing base (
1d252d7
) to head (2b05c6b
).
Additional details and impacted files
@@ Coverage Diff @@ ## master #1785 +/- ## ======================================= Coverage 85.87% 85.88% ======================================= Files 377 377 Lines 19720 19731 +11 Branches 3005 3008 +3 ======================================= + Hits 16935 16946 +11 Misses 2785 2785
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
pertrai1
pertrai1
approved these changes
Sep 3, 2025
raklaptudirm
raklaptudirm
approved these changes
Sep 4, 2025
@raklaptudirm
raklaptudirm
merged commit Sep 4, 2025
19ecb18
into
TheAlgorithms:master
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open in Gitpod know more
Describe your change:
This PR improves the
mean
function by:TypeError
if input is not an array or contains non-number elementsError
if array is emptyVitest
, which includes:null
,true
,'string'
The function now adheres more strictly to the expected behavior and is more robust against invalid input.
Checklist: