Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add Substitution Cipher algorithm and tests #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmohamedkhaled wants to merge 10 commits into TheAlgorithms:master
base: master
Choose a base branch
Loading
from mmohamedkhaled:add-substitution-cipher

Conversation

Copy link

@mmohamedkhaled mmohamedkhaled commented Apr 4, 2025

Open in Gitpod know more

Describe your change:

  • Add an algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames use the UpperCamelCase (PascalCase) style. There are no spaces in filenames.
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • All code is tested using Vitest and follows the ES Module syntax.
  • Code is formatted using Prettier.

Summary:

This PR adds a monoalphabetic Substitution Cipher to the ciphers/ directory.

  • Includes substitutionCipherEncryption and substitutionCipherDecryption functions
  • Validates key length and character set
  • Test coverage includes:
    • Encryption
    • Decryption
    • Non-alphabetic character handling
    • Invalid key rejection
  • All tests are passing using Vitest
  • Code formatted with Prettier

📚 Reference: Wikipedia – Substitution Cipher

Copy link

codecov-commenter commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (1d252d7) to head (25add22).

Additional details and impacted files 
@@ Coverage Diff @@
## master #1773 +/- ##
==========================================
+ Coverage 85.87% 85.91% +0.04% 
==========================================
 Files 377 378 +1 
 Lines 19720 19779 +59 
 Branches 3005 3017 +12 
==========================================
+ Hits 16935 16994 +59 
 Misses 2785 2785

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Author

This PR only introduces the Substitution Cipher and its test. I’ve noticed the CI flags code style/spelling issues in files like:

String/AlphaNumericPalindrome.js

Recursive/SubsequenceRecursive.js

Maths/MobiusFunction.js

These issues are pre-existing in the repository and not introduced by this PR. I have run Prettier on my changes, and there are no further modifications I can make to fix these unrelated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /