Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Resolve duplicate entries for sieve of eratosthenes #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@SpiderMath SpiderMath commented Jan 8, 2025

Fixes: #1666

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Further description

I kept the SieveOfEratosthenesIntArray implementation, renaming it to SieveOfEratosthenes, removed the boolean implementation, and wrote tests for the same. Apart from that, I've also added comments to conform to the algorithm comment standards.

Copy link
Contributor Author

I had initially worked on it but then stopped due to personal commitments, I'm back to contributing now, hence the number of commits is a bit much

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (85a55da) to head (fcd636a).

Additional details and impacted files 
@@ Coverage Diff @@
## master #1770 +/- ##
==========================================
- Coverage 85.11% 85.09% -0.02% 
==========================================
 Files 378 377 -1 
 Lines 19740 19717 -23 
 Branches 2967 2963 -4 
==========================================
- Hits 16801 16778 -23 
 Misses 2939 2939

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raklaptudirm raklaptudirm merged commit a62a46e into TheAlgorithms:master Jan 12, 2025
3 checks passed
@SpiderMath SpiderMath deleted the remove-Eratosthenes-intarray branch January 13, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu is a code owner

+1 more reviewer

@anandfresh anandfresh anandfresh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OTHER]: Duplicate entry of sieve of eratosthenes

AltStyle によって変換されたページ (->オリジナル) /