Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: Implementing Rabin-Karp algorithm for substring search #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rudrajiii wants to merge 2 commits into TheAlgorithms:master from Rudrajiii:master
Closed

Conversation

Copy link

@Rudrajiii Rudrajiii commented Oct 27, 2024

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link

Codecov Report

Attention: Patch coverage is 97.72727% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (55ff0ad) to head (91113a3).

Files with missing lines Patch % Lines
String/RabinKarp.js 97.72% 2 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #1757 +/- ##
==========================================
+ Coverage 84.76% 84.82% +0.05% 
==========================================
 Files 378 379 +1 
 Lines 19738 19826 +88 
 Branches 2957 2969 +12 
==========================================
+ Hits 16731 16817 +86 
- Misses 3007 3009 +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Author

@appgurueu @raklaptudirm

Copy link
Collaborator

This already exists: https://github.com/TheAlgorithms/JavaScript/blob/master/Search/RabinKarp.js, should perhaps be moved to string.

Copy link
Author

@appgurueu thank you for your review sir !! will add some new algo soon :)
appgurueu reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /