Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

test: added for Linear Search Algorithm #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 2 commits into TheAlgorithms:master from HRIDYANSHU054:test/LinearSearch
Dec 20, 2024

Conversation

Copy link
Contributor

@HRIDYANSHU054 HRIDYANSHU054 commented Oct 25, 2024 •
edited
Loading

Open in Gitpod know more

Describe your change:

Added tests and Wikipedia reference for Linear Search Algo

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link

codecov-commenter commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (ff314a2) to head (cbea1fe).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
+ Coverage 84.76% 85.11% +0.34% 
==========================================
 Files 378 378 
 Lines 19742 19740 -2 
 Branches 2955 2967 +12 
==========================================
+ Hits 16735 16801 +66 
+ Misses 3007 2939 -68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a trivial linear search needs a lot of test coverage but why not.

 

Co-authored-by: Lars Müller <34514239+appgurueu@users.noreply.github.com>
@raklaptudirm raklaptudirm merged commit 85a55da into TheAlgorithms:master Dec 20, 2024
3 checks passed
@HRIDYANSHU054 HRIDYANSHU054 deleted the test/LinearSearch branch December 23, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@raklaptudirm raklaptudirm raklaptudirm approved these changes

+1 more reviewer

@anandfresh anandfresh anandfresh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /