-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
docs: fixed misleading comment about the array method (forEach instead of reduce) used in AverageMean.js #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raklaptudirm
merged 3 commits into
TheAlgorithms:master
from
HRIDYANSHU054:fix/AverageMean
Oct 16, 2024
Merged
docs: fixed misleading comment about the array method (forEach instead of reduce) used in AverageMean.js #1727
raklaptudirm
merged 3 commits into
TheAlgorithms:master
from
HRIDYANSHU054:fix/AverageMean
Oct 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...d of reduce) used in AverageMean.js
@HRIDYANSHU054
HRIDYANSHU054
requested review from
raklaptudirm and
appgurueu
as code owners
October 10, 2024 13:15
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.76%. Comparing base (
ff314a2
) to head (d0e1ba9
).
Additional details and impacted files
@@ Coverage Diff @@ ## master #1727 +/- ## ========================================== - Coverage 84.76% 84.76% -0.01% ========================================== Files 378 378 Lines 19742 19738 -4 Branches 2955 2957 +2 ========================================== - Hits 16735 16731 -4 Misses 3007 3007
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
Just remove the comment. It adds no value.
...cessary operations.
@appgurueu Done.
Co-authored-by: Lars Müller <34514239+appgurueu@users.noreply.github.com>
appgurueu
appgurueu
approved these changes
Oct 10, 2024
@raklaptudirm please review the changes
anandfresh
anandfresh
approved these changes
Oct 11, 2024
raklaptudirm
raklaptudirm
approved these changes
Oct 16, 2024
@raklaptudirm
raklaptudirm
merged commit Oct 16, 2024
55ff0ad
into
TheAlgorithms:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Open in Gitpod know more
Describe your change:
what was wrong?
wrong array method in comment
Before:
After:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.