-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add algorithms for 2Sum, 3Sum, Kadane's Algorithm, and linked list pr... #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@karankumar12345
karankumar12345
requested review from
raklaptudirm and
appgurueu
as code owners
October 6, 2024 07:24
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.77%. Comparing base (
18da83a
) to head (2029064
).
Additional details and impacted files
@@ Coverage Diff @@ ## master #1716 +/- ## ========================================== + Coverage 84.65% 84.77% +0.11% ========================================== Files 378 382 +4 Lines 19744 19895 +151 Branches 2951 2978 +27 ========================================== + Hits 16715 16866 +151 Misses 3029 3029
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
appgurueu
appgurueu
requested changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please ideally keep it to one PR per addition, unless the algorithms are related.
- Please get rid of redundant algorithms. We already have Kadane's Algorithm for example.
- Try to make your algorithms compatible with existing data structures, e.g. our linked list implementation.
- CI is failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds algorithms for 2Sum, 3Sum, Kadane's Algorithm, and linked list problems including finding the intersection point and implementing the slow-fast pointer technique.
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are not.Fixes: #{$ISSUE_NO}
. (Replace{$ISSUE_NO}
with the actual issue number if applicable).