Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: improve space complexity of QuickSort algorithm #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DevAnuragT wants to merge 1 commit into TheAlgorithms:master
base: master
Choose a base branch
Loading
from DevAnuragT:improve-quicksort-space-complexity

Conversation

Copy link

@DevAnuragT DevAnuragT commented Oct 1, 2024

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Improved the space complexity of the QuickSort algorithm by removing additional arrays (GREATER and LESSER) and implementing in-place partitioning using swapping.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
    Fixes: [FEATURE]: Improve Quicksort Algorithm with Better Space Complexity #1703

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (9010481) to head (40a9414).

Additional details and impacted files 
@@ Coverage Diff @@
## master #1704 +/- ##
==========================================
+ Coverage 84.65% 84.68% +0.02% 
==========================================
 Files 378 378 
 Lines 19744 19775 +31 
 Branches 2951 2952 +1 
==========================================
+ Hits 16715 16746 +31 
 Misses 3029 3029

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not an improvement as-is. We already have an in-place quick sort. By optimizing the out of place variant, we're left with essentially a duplicate implementation. That's a downgrade.

Acceptable alternatives would be to refactor the implementations, making it more clear what distinguishes them and perhaps clearing up some variable names and comments, or perhaps even removing the out-of-place implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Improve Quicksort Algorithm with Better Space Complexity

AltStyle によって変換されたページ (->オリジナル) /