Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit hash #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohmmadAyesh wants to merge 2 commits into TheAlgorithms:master from mohmmadAyesh:commit-hash
Closed

Conversation

Copy link

@mohmmadAyesh mohmmadAyesh commented Mar 28, 2024

Open in Gitpod know more

Describe your change:

there was a commit that not belonging to any branch when i accidently merge my feature branch to another feature branch of mine to batch all document changing that i made into 1 PR so here is a pull request about a branch containing the commit that wasnt belonging to branch

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ x] I have read CONTRIBUTING.md.
  • [ x] This pull request is all my own work -- I have not plagiarized.
  • [ x] I know that pull requests will not be merged if they fail the automated tests.
  • [ x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x] All new JavaScript files are placed inside an existing directory.
  • [ x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link

codecov-commenter commented Mar 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.08%. Comparing base (bd34e9f) to head (c6b5dac).

Additional details and impacted files 
@@ Coverage Diff @@
## master #1652 +/- ##
==========================================
+ Coverage 84.07% 84.08% +0.01% 
==========================================
 Files 375 375 
 Lines 19688 19703 +15 
 Branches 2913 2914 +1 
==========================================
+ Hits 16552 16567 +15 
 Misses 3136 3136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

 

fix-jsdocs
 You are currently cherry-picking commit de118c6.
 it was about modifying the docstring in CheckPalindrome File
Copy link
Collaborator

appgurueu commented Mar 29, 2024 •
edited
Loading

Why not add this commit to the other PR? In fact this seems to be a subset of it: https://github.com/TheAlgorithms/JavaScript/pull/1647/files#diff-bda94ce5cced910661cfecb750d8bbcb8db8c9e6f1a067986cc912e9dff05ccf

@appgurueu appgurueu added the invalid Doesn't seem right label Mar 29, 2024
@mohmmadAyesh mohmmadAyesh deleted the commit-hash branch March 30, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu is a code owner

Assignees
No one assigned
Labels
invalid Doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /