Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

test: add missing test for SumOfGeometricProgression #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Member

@vil02 vil02 commented Feb 10, 2024

Open in Gitpod know more

Describe your change:

This PR adds a test covering this line:

  • Add missing test.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link

codecov-commenter commented Feb 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10febce) 83.45% compared to head (efe7ebb) 83.47%.

Additional details and impacted files 
@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
+ Coverage 83.45% 83.47% +0.02% 
==========================================
 Files 377 377 
 Lines 19745 19745 
 Branches 2906 2908 +2 
==========================================
+ Hits 16478 16482 +4 
+ Misses 3267 3263 -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 force-pushed the add_missing_test_geometric_prog branch from ba92697 to 52f811b Compare February 10, 2024 11:00
@vil02 vil02 force-pushed the add_missing_test_geometric_prog branch from 52f811b to efe7ebb Compare February 10, 2024 11:03
@vil02 vil02 marked this pull request as ready for review February 10, 2024 11:05
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(BTW, feel free to improve coverage of various algorithms in one go, to avoid overhead from constant PR back-and-forth.)

@raklaptudirm raklaptudirm merged commit 1ea7a5c into TheAlgorithms:master Feb 14, 2024
@vil02 vil02 deleted the add_missing_test_geometric_prog branch February 14, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /