Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DO NOT MERGE before adding the token] chore: update codecov-action to v4 #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appgurueu merged 1 commit into TheAlgorithms:master from vil02:update_codecov_action_to_v4
Jun 23, 2024

Conversation

Copy link
Member

@vil02 vil02 commented Feb 2, 2024

Open in Gitpod know more

Describe your change:

Same as TheAlgorithms/Rust#670 - it contains the description of the problem.

Before merging, please add the token from https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings as CODECOV_TOKEN into the repo secrets.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.

@vil02 vil02 marked this pull request as ready for review February 2, 2024 18:42
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aaa376) 82.44% compared to head (8176408) 82.44%.

Additional details and impacted files
@@ Coverage Diff @@
## master #1605 +/- ##
=======================================
 Coverage 82.44% 82.44% 
=======================================
 Files 377 377 
 Lines 19747 19747 
 Branches 2884 2885 +1 
=======================================
 Hits 16281 16281 
 Misses 3466 3466 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

It seems that in order to add the token, I would have to be logged in (on the codecov site) to access https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ? I'm slightly uncomfortable with this as it requests permission to "act on my behalf":

Screenshot from 2024年02月02日 20-47-06

Copy link
Member Author

vil02 commented Feb 2, 2024

It seems that in order to add the token, I would have to be logged in (on the codecov site) to access https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ?

Yes.

I'm slightly uncomfortable with this as it requests permission to "act on my behalf":

I agree.

Copy link
Collaborator

I bit the bullet and authorized CodeCov to obtain the token, but it turns out that I can't edit repo secrets since I do not have "admin" permissions. This will require @Panquesito7 or @AnupKumarPanwar I believe.

vil02 reacted with thumbs up emoji

Copy link
Member

@appgurueu You should have admin access to the repository now

@appgurueu appgurueu merged commit 9010481 into TheAlgorithms:master Jun 23, 2024
Copy link
Member Author

vil02 commented Jun 23, 2024

Just in case: please make sure that CODECOV_TOKEN is also added to the dependabot secrets (6e27235 adds dependabot).

@vil02 vil02 deleted the update_codecov_action_to_v4 branch June 23, 2024 12:19
Copy link
Collaborator

Just in case: please make sure that CODECOV_TOKEN is also added to the dependabot secrets (6e27235 adds dependabot).

Why would dependabot need the codecov token? It seems to work as-is: https://app.codecov.io/github/TheAlgorithms/JavaScript/commit/9010481c2930d65621f18f41c216f29fceaa8807

Copy link
Member Author

vil02 commented Jun 23, 2024

Without it, the UploadCoverageReport will fail for each PR created by dependabot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /