-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Create GenerateSubsets #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GenerateSubsets #1581
Conversation
@imshreya2000 pls add tests and some documentation
@CarlosZoft I have added the test and explanation. Kindly review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the files should be placed in Recursive/GenerateSubsets.js and Recursive/tests/GenerateSubsets.test.js respectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Call the parameter
arr, notnums. The implementation doesn't need to make any assumptions about the values inarr. - This should have a doc comment stating what this does (builds and returns a list of all subsets in lexicographic order). Also, consider using a generator rather than building a list; sometimes you want to iterate over all subsets without storing them all temporarily in memory (for example when solving hard optimization problems).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I would call this backtracking; to me it's just ordinary recursion:
Backtracking is a class of algorithms for finding solutions to some computational problems, notably constraint satisfaction problems, that incrementally builds candidates to the solutions, and abandons a candidate as soon as it determines that the candidate cannot possibly be completed to a valid solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example should be removed from this file (or converted into a JSDoc example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's in the other file. Remove this comment from the test file.
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.