Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: added implementation for average mode #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SpiderMath wants to merge 4 commits into TheAlgorithms:master
base: master
Choose a base branch
Loading
from SpiderMath:add-average-mode

Conversation

Copy link
Contributor

@SpiderMath SpiderMath commented Oct 18, 2023

This pull request aims to add the implementation for Average Mode
I did not however run npm run test, for it seems it modified over 700 files, many of which I didn't understand the reason for. Hence I just tried to stick to the standards by myself as much as I could.

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Contributor Author

@appgurueu and @raklaptudirm, sorry to ping, but could you please check this PR maybe? 😅

Copy link
Contributor Author

Hello? Anyone here? @appgurueu & @raklaptudirm?

Copy link
Member

Hmm I think this algorithm may be too trivial to warrant inclusion in the repo. @appgurueu what do you think?

Copy link
Contributor Author

Any updates? (I was away for a while)

Copy link
Collaborator

@appgurueu appgurueu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again sorry for the late reply; this got caught in the Hacktoberfest...

Code-wise this looks okay (formatting nitpick: Why no space before ( for flow control statements?). You should document what exactly this returns, though (sorted array of modes). Where does the "average" in the name come from?

The tests should use it.each.

This is relatively simple, but I think we can include it anyways; it implements an established concept from statistics, and is not too trivial.

counts.set(entry, count + 1)

if(max < count + 1)
max = count + 1
Copy link
Collaborator

@appgurueu appgurueu Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could write this as max = Math.max(max, count + 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /