-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
test: add tests for Eucledian GCD Algorithm #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have Maths/GetEuclidGCD.js (iterative). The iterative version is strictly better than the recursive one (doesn't waste stack space; JS can not be trusted to do tail call optimization).
So, the iterative version in Recursive/EucledianGCD.js should be removed. I'm not sure whether the recursive version should be kept.
Either way, the tests for the GCD should not be duplicated. These functions (Maths/GetEuclidGCD.js & recursive GCD) solve the same problem - and with the same time complexity even - and thus should use the same tests.
...tion of Eucledian GCD Algorithm
As said, I think the existing GCD tests should be reused (or the recursive function should be removed altogether, as it is strictly inferior).
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.