chore: update abs function #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ridge-kimani wants to merge 2 commits into TheAlgorithms:master from ridge-kimani:update-abs-fn

Closed

chore: update abs function #1472

ridge-kimani wants to merge 2 commits into TheAlgorithms:master from ridge-kimani:update-abs-fn

Conversation

ridge-kimani

Copy link

Contributor

@ridge-kimani ridge-kimani commented Oct 7, 2023

Open in Gitpod know more

Describe your change:

Updates the abs algorithm to use Maths.abs function which in turn makes the function run faster.
Update an algorithm

Checklist:

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

rnkimani added 2 commits

October 7, 2023 14:21

@rnkimani


 chore: update abs function to use Math utility

43695cc

@rnkimani


 chore: format with prettier

2dc063f

@ridge-kimani ridge-kimani requested review from raklaptudirm and appgurueu as code owners

October 7, 2023 11:27

@appgurueu

Copy link

Collaborator

appgurueu commented Oct 7, 2023

Sorry, but the purpose of this repo is to show how one would implement these, not how to use the standard library (that said, abs is trivial and not useful given its redundancy with the stdlib and thus wouldn't be accepted if it were to be PR'd today).