Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Rahul🍉 #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajanarahul93 wants to merge 1 commit into TheAlgorithms:master from rajanarahul93:master
Closed

Rahul🍉 #1357

rajanarahul93 wants to merge 1 commit into TheAlgorithms:master from rajanarahul93:master

Conversation

Copy link

@rajanarahul93 rajanarahul93 commented Sep 9, 2023 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See our contribution guidelines. I also think this "algorithm" is pretty much trivial yet oddly specific and thus doesn't really warrant inclusion; besides, it could also be written more concisely using filter (arguably wasting memory for a temp array) and reduce (you could also save yourself the filter by using a ternary in reduce though).

@appgurueu appgurueu added the invalid Doesn't seem right label Sep 9, 2023
Copy link
Author

rajanarahul93 commented Sep 9, 2023 via email

Agreed!
...
On Sat, 9 Sep, 2023, 2:09 pm Lars Müller, ***@***.***> wrote: Closed #1357 <#1357>. — Reply to this email directly, view it on GitHub <#1357 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5ME3FYZSV6OI5EHORZYIYDXZQTN7ANCNFSM6AAAAAA4RGCQNM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
invalid Doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /