-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Added Miller Rabin Primality Test #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Miller Rabin Primality Test #1321
Conversation
someone help with indentation pls , thx in advance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Try adding more comments to the code (but do not add redundant comments).
- Add tests.
- What are the changes to
package.jsonandpackage-lock.jsonfor? They look accidental to me.
someone help with indentation pls , thx in advance
You should be able to simply run https://standardjs.com/ against your code.
yaa actually i had added npm format package
now it works, thx
deleted
any further changes to be done ? @appgurueu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing tests and comments. For example you use exponentation by squaring, but don't explain this using comments. Also still contains the unrelated package[-lock].json changes.
should i add more comments explaining this algorithm?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Uh oh!
There was an error while loading. Please reload this page.
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.