-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
docs: improve the contributing guidelines #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Panquesito7
Panquesito7
added
the
documentation
PR that adds or fixes docs; issue that points out issues with the docs
label
Dec 18, 2022
@Panquesito7
Panquesito7
requested review from
raklaptudirm and
appgurueu
as code owners
December 18, 2022 01:54
appgurueu
appgurueu
approved these changes
Dec 18, 2022
raklaptudirm
raklaptudirm
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open in Gitpod know more
Describe your change:
Checklist:
(削除) This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. (削除ここまで)(削除) All new JavaScript files are placed inside an existing directory. (削除ここまで)(削除) All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare not (削除ここまで)(削除) All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation. (削除ここまで)Fixes: #{$ISSUE_NO}.