Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

algorithm: signum #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 6 commits into TheAlgorithms:master from SpiderMath:add-signum
Dec 8, 2022
Merged

algorithm: signum #1266

raklaptudirm merged 6 commits into TheAlgorithms:master from SpiderMath:add-signum
Dec 8, 2022

Conversation

Copy link
Contributor

@SpiderMath SpiderMath commented Nov 26, 2022 •
edited by gitpod-io bot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

This PR is to add the implementation of the signum function. TheAlgorithms entry is here

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; note: this will currently return 1 for NaN; returning NaN would be more sensible IMO.

Copy link
Contributor Author

Oh yes. I completely missed that case. I'm sorry. Thanks for pointing it out, I'll fix it right away.

@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Nov 27, 2022
Copy link
Collaborator

You still have an else in each branch. Generally using else-ifs even if you are returning on each branch is not necessarily bad practice because it may help improve readability (so I'm fine with it either way), but in this particular example, your ifs are simple enough that you should just get rid of the redundant elses as the returns already do the job.
SpiderMath reacted with thumbs up emoji

@raklaptudirm raklaptudirm changed the title (削除) feat: Added implementation for Signum function (削除ここまで) (追記) algorithm: signum (追記ここまで) Dec 8, 2022
@raklaptudirm raklaptudirm merged commit 65cceae into TheAlgorithms:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /