Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

add majority element #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shivamp1998 wants to merge 10 commits into TheAlgorithms:master from shivamp1998:master
Closed

Conversation

Copy link

@shivamp1998 shivamp1998 commented Oct 6, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@@ -0,0 +1,48 @@
/**
Copy link
Collaborator

@appgurueu appgurueu Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs to be on the findMajorityElement function.

return false
}

function findMajority (array) {
Copy link
Collaborator

@appgurueu appgurueu Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this to findMajorityElement and move the JSDoc comment right above this.

@@ -0,0 +1,16 @@
import { findMajority } from '../MajorityElement'

describe('Majority element cases', () => {
Copy link
Collaborator

@appgurueu appgurueu Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please inline your arrays for all test cases.

const Array = [1, 2, 3, 4, 5]
expect(findMajority(Array)).toEqual(-1)
})
it('test1 with majority', () => {
Copy link
Collaborator

@appgurueu appgurueu Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless description.

const Array = [3, 3, 4, 2, 4, 4, 2, 4, 4]
expect(findMajority(Array)).toEqual(4)
})
it('test2 with majority', () => {
Copy link
Collaborator

@appgurueu appgurueu Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless description.

Copy link
Author

I dont know why other files are changing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /