Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: DateToDay #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 9 commits into TheAlgorithms:master from chetanppatil:master
Oct 10, 2022
Merged

fix: DateToDay #1125

raklaptudirm merged 9 commits into TheAlgorithms:master from chetanppatil:master
Oct 10, 2022

Conversation

Copy link
Contributor

@chetanppatil chetanppatil commented Oct 5, 2022 •
edited by appgurueu
Loading

Open in Gitpod know more

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
 

- updated functionality to use Zeller's congruence to find day
- updated test cases
@chetanppatil chetanppatil changed the title (削除) :fix: DayToDay giving wrong day (削除ここまで) (追記) 🐛 DayToDay giving wrong day (追記ここまで) Oct 5, 2022
@chetanppatil chetanppatil changed the title (削除) 🐛 DayToDay giving wrong day (削除ここまで) (追記) 🐛 DateToDay giving wrong day (追記ここまで) Oct 5, 2022
Copy link
Contributor Author

@appgurueu Could you please share what are your thoughts on this PR?
It will be really helpful for me if there are any improvements I can take care of next time.
Thanks

@appgurueu appgurueu linked an issue Oct 7, 2022 that may be closed by this pull request 
- updated comments
- removed monthList completely
- converted daysName List to an array
@appgurueu appgurueu changed the title (削除) 🐛 DateToDay giving wrong day (削除ここまで) (追記) Fix DateToDay (追記ここまで) Oct 8, 2022
@appgurueu appgurueu mentioned this pull request Oct 8, 2022
9 tasks
@appgurueu appgurueu added the fix Fixes a bug label Oct 8, 2022
@raklaptudirm raklaptudirm changed the title (削除) Fix DateToDay (削除ここまで) (追記) fix: DateToDay (追記ここまで) Oct 10, 2022
@raklaptudirm raklaptudirm merged commit d94929e into TheAlgorithms:master Oct 10, 2022
Copy link
Contributor Author

Thank you @appgurueu @raklaptudirm for merging my PR.

Thank you @appgurueu for all your valuable review comments and suggestion, I really learned a lot from you.
appgurueu reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateToDay.js giving wrong day

AltStyle によって変換されたページ (->オリジナル) /