Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add: countSubstrings function implementation #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 3 commits into TheAlgorithms:master from ajinkyac03:develop
Sep 7, 2022

Conversation

Copy link
Contributor

@ajinkyac03 ajinkyac03 commented Sep 6, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

Fixes #1090

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about overlapping substrings? I might expect countSubstrings("aaa", "aa") to be 2. Currently this is undocumented & untested behavior.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Runtime is O(n2) due to the naive implementation.

@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Sep 6, 2022
@raklaptudirm raklaptudirm changed the title (削除) Added countSubstrings function implementation. (削除ここまで) (追記) add: countSubstrings function implementation. (追記ここまで) Sep 7, 2022
@raklaptudirm raklaptudirm changed the title (削除) add: countSubstrings function implementation. (削除ここまで) (追記) add: countSubstrings function implementation (追記ここまで) Sep 7, 2022
@raklaptudirm raklaptudirm merged commit 6c718c0 into TheAlgorithms:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Count occurrences of substring in a string function implementation not there

AltStyle によって変換されたページ (->オリジナル) /