-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
algorithm: mobius function implementation #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raklaptudirm
merged 7 commits into
TheAlgorithms:master
from
itsAkshayDubey:add-mobius-function-implementation
Sep 6, 2022
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
01785bf
feat: Add mobius function implementation
itsAkshayDubey 376edfe
test: Add tests for mobius function
itsAkshayDubey 47ded10
fix: Code style fixes
itsAkshayDubey f3ec996
fix: Code style fixes
itsAkshayDubey 148ef6c
fix: Store prime factors in a variable & add throw error
itsAkshayDubey 2affaa1
fix: Fix unit tests for zero and negative numbers
itsAkshayDubey 844bc2a
fix: Minor code style fixes
itsAkshayDubey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Author: Akshay Dubey (https://github.com/itsAkshayDubey) | ||
* Mobius Function: https://en.wikipedia.org/wiki/M%C3%B6bius_function | ||
* For any positive integer n, define μ(n) as the sum of the primitive nth roots of unity. | ||
* It has values in {−1, 0, 1} depending on the factorization of n into prime factors: | ||
* μ(n) = +1 if n is a square-free positive integer with an even number of prime factors. | ||
* μ(n) = −1 if n is a square-free positive integer with an odd number of prime factors. | ||
* μ(n) = 0 if n has a squared prime factor. | ||
*/ | ||
|
||
/** | ||
* @function mobiusFunction | ||
* @description -> This method returns μ(n) of given number n | ||
* returns 1 when number is less than or equals 1 | ||
* or number has even number of prime factors | ||
* returns 0 when number has repeated prime factor | ||
* returns -1 when number has odd number of prime factors | ||
* @param {Integer} number | ||
* @returns {Integer} | ||
*/ | ||
|
||
import { PrimeFactors } from './PrimeFactors.js' | ||
export const mobiusFunction = (number) => { | ||
const primeFactorsArray = PrimeFactors(number) | ||
if (number <= 0) { | ||
throw new Error('Number must be greater than zero.') | ||
} | ||
return primeFactorsArray.length !== new Set(primeFactorsArray).size ? 0 : primeFactorsArray.length % 2 === 0 ? 1 : -1 | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { mobiusFunction } from '../MobiusFunction' | ||
|
||
const expectedValuesArray = [1, -1, -1, 0, -1, 1, -1, 0, 0, 1, -1, 0, -1, 1, 1, 0, -1, 0, -1, 0, 1, 1, -1, 0, 0, 1, 0, 0, -1, -1, -1, 0, 1, 1, 1, 0, -1, 1, 1, 0, -1, -1, -1, 0, 0, 1, -1, 0, 0, 0, 1, 0, -1, 0, 1, 0, 1, 1, -1, 0, -1, 1, 0, 0, 1, -1, -1, 0, 1, -1, -1, 0, -1, 1, 0, 0, 1, -1, -1, 0, 0, 1, -1, 0, 1, 1, 1, 0, -1, 0, 1, 0, 1, 1, 1, 0, -1, 0, 0, 0] | ||
|
||
describe('Testing mobius function', () => { | ||
for (let i = 1; i <= 100; i++) { | ||
it('Testing for number = ' + i + ', should return ' + expectedValuesArray[i], () => { | ||
expect(mobiusFunction(i)).toBe(expectedValuesArray[i - 1]) | ||
}) | ||
} | ||
|
||
it('should throw error when supplied negative numbers', () => { | ||
expect(() => { mobiusFunction(-1) }).toThrow(Error) | ||
}) | ||
|
||
it('should throw error when supplied zero', () => { | ||
expect(() => { mobiusFunction(0) }).toThrow(Error) | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.