Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Unroll matrix #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatthewPalmer9 wants to merge 8 commits into TheAlgorithms:master
base: master
Choose a base branch
Loading
from MatthewPalmer9:UnrollMatrix

Conversation

Copy link
Contributor

@MatthewPalmer9 MatthewPalmer9 commented Aug 6, 2022

Open in Gitpod know more

Describe your change:

  • [ x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ x ] I have read CONTRIBUTING.md.
  • [ x ] This pull request is all my own work -- I have not plagiarized.
  • [ x ] I know that pull requests will not be merged if they fail the automated tests.
  • [ x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x ] All new JavaScript files are placed inside an existing directory.
  • [ x ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ x ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ x ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.


// sweep top to right
if (matrix.length > 0) {
console.log(...matrix.shift())
Copy link
Collaborator

@appgurueu appgurueu Aug 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pass a visitor function instead of hardcoding console.log (or even better, turn the entire function into an iterator).

* @function UnrollMatrix
* @description Traverses/Unrolls array of arrays recursively until nothing is left.
* @param {Array} matrix - The input array of arrays
* @return {Array} matrix - The empty output array => [].
Copy link
Collaborator

@appgurueu appgurueu Aug 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would a constant output be useful?

@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Aug 7, 2022
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm stale Closed due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /