Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

TreeTraversal added #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ram123-debug wants to merge 9 commits into TheAlgorithms:master from ram123-debug:master
Closed

Conversation

Copy link

@ram123-debug ram123-debug commented Jul 16, 2022 •
edited
Loading

BSTree traversal like inOrder, preOrder and postOrder functions are added with O(n) time and O(n) space complexity

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
 

inOrder, preOrder and postOrder functions are added with O(n) time and O(n) space complexity
@raklaptudirm raklaptudirm added changes required This pull request needs changes code style issue Failing style checks algorithm Adds or improves an algorithm labels Jul 16, 2022
Copy link
Author

Not able meet your requirement , need help

Copy link
Member

Please elaborate what you need help on.

Copy link
Author

Not able to pass the the Continuous Integration / Code style and tests (pull_request) . Please fix it

Copy link
Member

You must install the standard.js package and run the standard --fix . command on the files.

Copy link
Author

standard fix is done

@raklaptudirm raklaptudirm added ESM required Convert code to ECMAScript Modules (ESM) and removed code style issue Failing style checks labels Jul 16, 2022
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting stuff.

@raklaptudirm raklaptudirm removed changes required This pull request needs changes ESM required Convert code to ECMAScript Modules (ESM) labels Jul 16, 2022
Copy link
Member

@CarlosZoft CarlosZoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Copy link
Collaborator

@appgurueu appgurueu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it apparent that these are binary tree traversals rather than general tree traversals.

I also don't like pushing the results to an array, I'd rather use a visitor or generator pattern here as to not incur the O(n) space complexity.

Furthermore, please consider integrating this (making it a bunch of methods) with our existing binary (search) tree implementation.

Also please add tests & some more comments.

@appgurueu appgurueu added the changes required This pull request needs changes label Aug 3, 2022
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

+1 more reviewer

@CarlosZoft CarlosZoft CarlosZoft approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm changes required This pull request needs changes stale Closed due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /