-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Fibonacci.js
overhaul
#1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fibonacci.js
overhaul
#1049
Conversation
Also added support to `Identity`, `matrixMultiply`, and `matrixExpo`
This pull request introduces 1 alert when merging 33df079 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Useless comparison test
This pull request introduces 1 alert when merging f4f1d53 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Useless comparison test
This pull request introduces 1 alert when merging 2bcbc58 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Useless comparison test
This pull request introduces 1 alert when merging 3d865f3 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Useless comparison test
This pull request introduces 1 alert when merging 0dc81a8 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Useless comparison test
This pull request introduces 1 alert when merging 1f61f51 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Useless comparison test
FibonacciMatrixExpo
(削除ここまで)FibonacciMatrixExpo
and negatives for the entire Fibonacci.js (追記ここまで)
FibonacciMatrixExpo
and negatives for the entire Fibonacci.js (削除ここまで)BigInt
& negative support to Fibonacci.js
(追記ここまで)
This pull request introduces 1 alert when merging b2101fc into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Useless comparison test
This pull request introduces 1 alert when merging c5fe0b5 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Useless comparison test
This wasn't originally part of the PR, but I thought it would be good to add
This pull request introduces 3 alerts when merging 787fd75 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Expression has no effect
- 1 for Assignment to property of primitive value
- 1 for Useless comparison test
BigInt
& negative support to Fibonacci.js
(削除ここまで)BigInt
& negative support to Fibonacci.js
, also generator fn (追記ここまで)
This pull request introduces 3 alerts when merging 028ebe9 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Expression has no effect
- 1 for Assignment to property of primitive value
- 1 for Useless comparison test
BigInt
& negative support to Fibonacci.js
, also generator fn (削除ここまで)Fibonacci.js
overhaul (追記ここまで)
This pull request introduces 3 alerts when merging 69bbe51 into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Expression has no effect
- 1 for Assignment to property of primitive value
- 1 for Useless comparison test
- 1 for Assignment to property of primitive value
(削除) lol, the bot can't recognize the destructuring assignment syntax (削除ここまで)
My bad, I didn't recognize that the array literal was interpreted as subscript, lol
This pull request introduces 3 alerts when merging 82861ef into 95a8ec0 - view on LGTM.com
new alerts:
- 1 for Expression has no effect
- 1 for Assignment to property of primitive value
- 1 for Useless comparison test
I tried removing the trailing whitespace, but somehow I can't find them. It seems those are control chars.
Update: Not even VScode can find them. I activated control char rendering and whitespace rendering, no results. I clicked the "Remove all trailing whitespace" option, but absolutely nothing changed. This seems to be a bug
Use standard.js
to style your code and remove trailing whitespace. Make sure to read CONTRIBUTING.md
before making any contributions.
Make sure to read
CONTRIBUTING.md
I already did it, many times, and thoroughly. I just prefer to fix style errors manually. But it seems the only solution now is to use SJS. I'll install NPM & Node now
Wait, now I read the problem is in Fibonacci.test.js
, not Fibonacci.js
🤦♂️. Fixing now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a significant improvement. I've got some minor comments regarding consistency.
21ff3fd
Uh oh!
There was an error while loading. Please reload this page.
Added
BigInt
support toFibonacciMatrixExpo
,Identity
,matrixMultiply
, andmatrixExpo
. And added the extension to negative domain for all fns in that file. And added a generator function example. Also corrected indices to return 0 if the input arg is 0 (because that's the 0th Fib).Fixes: #1047
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.