-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
More accurate error message at IsDivisible
#1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(consider lowercasing the r from real)
(consider lowercasing the
rfromreal)
Why? I thought it was a good idea to make it uppercase to distinguish between "real" (reality) and "Real" (the set of all non-complex rational and irrational numbers). But, for consistency, it may also be a good idea to lowercase it
Why? I thought it was a good idea to make it uppercase to distinguish between "real" (reality) and "Real" (the set of all non-complex rational and irrational numbers). But, for consistency, it may also be a good idea to lowercase it
"real number" already is an unambiguous term and thus fine - no need to bend the rules of capitalization to emphasize the "real" property.
Ok then I'll change it now
Uh oh!
There was an error while loading. Please reload this page.
Open in Gitpod know more
Describe your change:
This PR edits the error message in that file (Maths/IsDivisible.js) to be more accurate to its context. Because
InfinityandNaNaren't valid Real numbers.Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.