-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add the Collatz Conjecture #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not everyone is familiar with the collatz conjecture. Add some explanatory comments and Wikipedia links.
Yep, will add those tomorrow.
For now, it's time to sleep 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are now broken ((削除) and I still don't see cycle detection, although (削除ここまで) this is probably not necessary considering there is no known cycle within double bounds except for (1, 2) anyways)
Co-authored-by: Rak Laptudirm <rak@laptudirm.com>
This is currently unable to disprove the Collatz conjecture as it just won't halt as it lacks cycle detection (which would have to be implemented using a hashmap); it can merely show that certain sequences don't disprove the Collatz conjecture. I suggest focusing on the sequence rather than the conjecture.
Still reads "collatz conjecture" in numerous places...
Still reads "collatz conjecture" in numerous places...
As in the comments? Or the code?
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.