-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add test to KeywordShiftedAlphabet algorithm #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor code deduplication is possible but it's fine either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And roundabout tests:
randomData === decrypt(encrypt(randomData))
And roundabout tests:
randomData === decrypt(encrypt(randomData))
That's effectively implemented manually here (encrypting hello world, then decrypting it). I agree that it could be implemented "better" as roundabout.
ok, then I delete this pr and send a new one
ok, then I delete this pr and send a new one
Please commit to the PR instead of opening a new PR each time.
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.