Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Upgraded Algorithm of alpha numeric palindrome #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 52 commits into TheAlgorithms:master from fahimfaisaal:upgrade-alphaNumericPalindrome
May 7, 2022
Merged

Upgraded Algorithm of alpha numeric palindrome #1006

raklaptudirm merged 52 commits into TheAlgorithms:master from fahimfaisaal:upgrade-alphaNumericPalindrome
May 7, 2022

Conversation

Copy link
Contributor

@fahimfaisaal fahimfaisaal commented May 6, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Optimized the traverse algo n to n / 2
  • Fixed some spell mistake & updated jsDocs
  • Modified the test cases

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

fahimfaisaal and others added 30 commits March 2, 2022 13:15 
used Map instead of object & used the JSON.stringfy method for generate a valid string as a key
Copy link
Contributor Author

@appgurueu Its node version should be updated cause String.prototype.at method is available on LTS v16.15.0

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm code quality Code quality improvement documentation PR that adds or fixes docs; issue that points out issues with the docs tests Adds or fixes tests; issue that points out bugs in the tests labels May 7, 2022
Copy link
Member

@fahimfaisaal The tests are still failing.

Copy link
Contributor Author

@raklaptudirm MDN said that after node v16.6.0 this method should work perfectly. and It's working perfectly on my machine when I'm using v16.15.0 via nvm.

Copy link
Member

The runner is using that version:

Found in cache @ /opt/hostedtoolcache/node/16.15.0/x64

Copy link
Member

@fahimfaisaal try updating the dependencies in package.json.

Copy link
Contributor Author

@raklaptudirm Done 😀
raklaptudirm reacted with thumbs up emoji

@raklaptudirm raklaptudirm merged commit cbc669a into TheAlgorithms:master May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm code quality Code quality improvement documentation PR that adds or fixes docs; issue that points out issues with the docs tests Adds or fixes tests; issue that points out bugs in the tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /