Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improved the complexity of dequeue O(n) to O(1) #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 46 commits into TheAlgorithms:master from fahimfaisaal:upgrade-queue
May 6, 2022
Merged

Improved the complexity of dequeue O(n) to O(1) #1005

raklaptudirm merged 46 commits into TheAlgorithms:master from fahimfaisaal:upgrade-queue
May 6, 2022

Conversation

Copy link
Contributor

@fahimfaisaal fahimfaisaal commented May 6, 2022

Open in Gitpod know more

Describe your change:

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

fahimfaisaal and others added 30 commits March 2, 2022 13:15
used Map instead of object & used the JSON.stringfy method for generate a valid string as a key
fahimfaisaal and others added 14 commits March 29, 2022 08:06
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the issues and remove all capacity-related code. Otherwise LGTM.

@appgurueu appgurueu added code quality Code quality improvement performance Performance improvement labels May 6, 2022
@raklaptudirm raklaptudirm added the algorithm Adds or improves an algorithm label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm code quality Code quality improvement performance Performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /