-
Notifications
You must be signed in to change notification settings - Fork 20.4k
fix(MiniMaxAlgorithm): correct power-of-2 validation and log2 handling + add unit tests #6581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Harsh-dubey-git
wants to merge
1
commit into
TheAlgorithms:master
from
Harsh-dubey-git:fix-minimax-bug
Open
fix(MiniMaxAlgorithm): correct power-of-2 validation and log2 handling + add unit tests #6581
Harsh-dubey-git
wants to merge
1
commit into
TheAlgorithms:master
from
Harsh-dubey-git:fix-minimax-bug
+102
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Harsh-dubey-git
Harsh-dubey-git
requested review from
DenizAltunkapan,
yanglbme and
alxkm
as code owners
October 1, 2025 19:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
MiniMaxAlgorithm.java
related to incorrect validation of power-of-2 array lengths in thesetScores()
method and improves edge case handling in thelog2()
method. Additionally, it adds a comprehensive JUnit 5 test suite to verify correctness and prevent future regressions.Changes Made
setScores()
null
and empty arrays.(length & (length - 1)) == 0
.IllegalArgumentException
for invalid inputs.log2()
Unit Tests
MiniMaxAlgorithmTest.java
includes tests for:setScores()
inputs.log2()
.miniMax()
computation for deterministic score arrays.log2()
method.Other Improvements