-
Notifications
You must be signed in to change notification settings - Fork 20.2k
Document hash() limitations in BucketSort; add tests showing distribution behavior #6511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
distribution behavior
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.11%. Comparing base (79dc0b4) to head (635fcdb).
Additional details and impacted files
@@ Coverage Diff @@ ## master #6511 +/- ## ============================================ + Coverage 75.10% 75.11% +0.01% Complexity 5571 5571 ============================================ Files 685 685 Lines 19307 19307 Branches 3732 3732 ============================================ + Hits 14500 14502 +2 + Misses 4245 4244 -1 + Partials 562 561 -1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Took a while to get the clang-format right but it should be good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why you didn't put your Tests in the exististing BucketSortTest ? @Leogricci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the issue only related to the particular case of the hash function i thought it might be better to create another test class, but I realize now it just makes it harder to find. Sorry for the inconvenience, I will modify it now.
Relates to #6503
distribution behavior
Context
Documents the behavior and limitations of
hash()inBucketSort. The current logic treatscompareToas if it returned a numeric distance. For numerics,compareToyields only -1/0/1 (order), and for non-numeric types (e.g.,String) the magnitude reflects lexicographic code-point differences rather than proportional spacing. Sorting remains correct due to per-bucket sorting and concatenation, but the resulting bucket distribution is not a meaningful proportional mapping.Changes
hash()explaining limitations and the degeneratemin == maxcase.BucketSortHashBehaviorTestto demonstrate:compareTois sign-only).Observed output (examples)
All-equal case -> bucket index: 0
Value 10 -> bucket 0
Value 20 -> bucket 3
Value 30 -> bucket 3
Value 40 -> bucket 3
Value "apple" -> bucket 0
Value "banana" -> bucket 1
Value "carrot" -> bucket 3
Notes
No algorithm/signature change; documentation + tests only (for learners).
clang-format -i --style=file path/to/your/file.java