-
Notifications
You must be signed in to change notification settings - Fork 20.2k
fix: revert ReverseStack deletion and verify linting (#6474) #6494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert ReverseStack deletion and verify linting (#6474) #6494
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.10%. Comparing base (3f195c2) to head (c13bf51).
Additional details and impacted files
@@ Coverage Diff @@ ## master #6494 +/- ## ============================================ - Coverage 75.11% 75.10% -0.01% + Complexity 5574 5571 -3 ============================================ Files 687 686 -1 Lines 19318 19307 -11 Branches 3732 3732 ============================================ - Hits 14510 14500 -10 Misses 4245 4245 + Partials 563 562 -1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! Now please resolve the format issues to fix the failing workflows @VickySource
Hi @DenizAltunkapan, thanks for reviewing!
I have fixed the formatting using clang-format as requested and pushed the changes.
Could you please review again when you have time?
@VickySource I accidentally missed this earlier, but why did you undo the deletion of the Recursion classes? It was correct to delete ReverseStackUsingRecursion and the according test class. Please delete them so we can merge afterwards ;)
Hi @DenizAltunkapan, I have deleted both ReverseStackUsingRecursion.java and ReverseStackUsingRecursionTest.java as requested. The branch is now updated and ready for review.
3961b1d
into
TheAlgorithms:master
Context
The ReverseStackUsingRecursion.java implementation and ReverseStackUsingRecursionTest.java were accidentally deleted.
This PR restores both files and ensures they meet the project's style and linting requirements.
Changed
Verified formatting and linting:
Ran mvn checkstyle:check → BUILD SUCCESS
Spotless plugin not configured in the project → performed manual verification.
Verification steps performed
Confirmed both files match the upstream versions (no logic change).
Checked compilation → successful.
Lint check passed with no issues.
Notes for Reviewers
Only file restoration and formatting verification, And code logic changes.
Safe to merge — should restore repository consistency without conflicts.