-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: add GlobalUsings.cs with project-wide using directives for Algorithms folder #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add GlobalUsings.cs with project-wide using directives for Algorithms folder #522
Conversation
1402cbe to
cba8abb
Compare
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.15%. Comparing base (1b9aa7e) to head (d4bc12a).
Additional details and impacted files
@@ Coverage Diff @@ ## master #522 +/- ## ========================================== - Coverage 95.19% 95.15% -0.04% ========================================== Files 272 272 Lines 10921 10921 Branches 1536 1536 ========================================== - Hits 10396 10392 -4 - Misses 400 403 +3 - Partials 125 126 +1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
@Copilot
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a global using directives file for the Algorithms folder to centralize common namespaces and reduce boilerplate code across the solution. The changes remove redundant using statements from source files while maintaining functionality through the global imports.
- Adds GlobalUsings.cs to centralize using directives for the Algorithms folder
- Removes redundant using statements from 100+ files in the Algorithms directory
- Improves code readability and maintainability by eliminating boilerplate
Comments suppressed due to low confidence (5)
Algorithms/Strings/Similarity/OptimalStringAlignment.cs:1
- ArgumentNullException.ThrowIfNull expects the parameter value, not the parameter name. It should be ArgumentNullException.ThrowIfNull(firstString) and ArgumentNullException.ThrowIfNull(secondString).
namespace Algorithms.Strings.Similarity
Algorithms/Other/SieveOfEratosthenes.cs:1
- [nitpick] Consider adding a space after 'for' keyword for consistency with the project's formatting style, as seen in the corrected line 41 in MakeChangeSequence.cs.
namespace Algorithms.Other;
Algorithms/Other/SieveOfEratosthenes.cs:1
- [nitpick] Consider adding a space after 'for' keyword for consistency with the project's formatting style, as seen in the corrected line 41 in MakeChangeSequence.cs.
namespace Algorithms.Other;
Algorithms/Other/SieveOfEratosthenes.cs:1
- [nitpick] Consider adding a space after 'for' keyword for consistency with the project's formatting style, as seen in the corrected line 41 in MakeChangeSequence.cs.
namespace Algorithms.Other;
Algorithms/Knapsack/BranchAndBoundKnapsackSolver.cs:1
- [nitpick] Consider adding a space after 'if' keyword for consistency with the project's formatting style, as seen in similar corrections throughout the codebase.
namespace Algorithms.Knapsack;
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Uh oh!
There was an error while loading. Please reload this page.
Description
This PR contains the following points:
NOTE: These Changes are only done for the Algorithms folder as the file changes were more than 100 files.
Issue link: #520